Closed fedde-s closed 6 years ago
@rnugraha, could you review whether you agree with this refactoring, and especially whether the dependency version upgrade is correct?
The npm
command seems to want me to update package-lock.json
as well now that the dependencies have changed. should I include that change in the commit?
Please commit package-lock.json as well
I updated package-lock.json
, and rebased the patches to resolve the merge conflicts.
@rnugraha is this ready to be merged?
Will close this since this is no longer necessary
I think it is as necessary as it ever was, to make the component easier to improve on and potentially more accessible.
@rnugraha: done.
Using on the
value
property directly allows the component to no longer keep anisSelected
flag updated in option objects, which simplifies the code substantially. Once this has been factored out, it can also benefit from the toggling functionality built into the underlying react-select component instead of a customonChange
handler. None of this should affect the functionality in any way, but it does require an update to the current release of react-select.