search

thehyve / transmart-core

Core components and documentation of the tranSMART platform. https://i2b2transmart.org/
GNU General Public License v3.0
13 stars 13 forks source link

Made BIOMART_PASSWORD configurable #473

Closed tgymnich closed 4 years ago

tgymnich commented 5 years ago

Fixes #472

I still need to test this! Will update the PR once I got the chance to test this.

tgymnich commented 4 years ago

Testing is done. It works.

tgymnich commented 4 years ago

any updates on this?

gijskant commented 4 years ago

Thanks for the change. One remark: could you please name the variable BIOMART_USER_PASSWORD or BIOMART_USER_PWD for consistency with, e.g., https://github.com/thehyve/transmart-core/blob/dev/transmart-data/vars.sample#L84. The biomart schema/user and the biomart_user schema/user are different things. When changed, we will soon merge your two PRs for making the database password configurable.