[tslint] Consider enabling more rules

theia-ide / sprotty

A next-gen web-based graphics framework

Apache License 2.0

138 stars 23 forks source link

[tslint] Consider enabling more rules #123

Closed JanKoehnlein closed 6 years ago

JanKoehnlein commented 7 years ago

When enabling the linter, I've disabled some rules in the tslint.json.

The most striking one is "forin": false. It reports an error in about 8 cases and I am not sure whether or how we should deal with that. We should have a look at that after going public.

JanKoehnlein commented 7 years ago

@jbicker could you have a look at the forin issue?

spoenemann commented 6 years ago

I've reworked the TSLint configuration in #204. The forin rule is now active since it seems to make sense to avoid it unless necessary, see the MDN article.