search

theia-ide / sprotty

A next-gen web-based graphics framework
Apache License 2.0
138 stars 23 forks source link

[build] find out why sprotty has circular dependencies on Windows #131

Closed JanKoehnlein closed 7 years ago

JanKoehnlein commented 7 years ago

Webpack reports a circular dependency when sprotty is built on windows. I disabled failOnError in https://github.com/TypeFox/sprotty/commit/f5c1b648cfbb2a7ca3322238ba24051a8ec48bcb such that it runs, and the result looks good. Nevertheless we should find out what's going wrong there.

JanKoehnlein commented 7 years ago

I guess we cannot do much about this, as it is not in our code but in Inversify