search

theia-ide / sprotty

A next-gen web-based graphics framework
Apache License 2.0
138 stars 23 forks source link

Fixed DockerFile and add docker-compose.yml file #194

Closed heeckhau closed 6 years ago

heeckhau commented 6 years ago

Use yarn instead of npm in DockerFile

heeckhau commented 6 years ago

Hi Jan, this does not have to be there. I find the docker-compose commands easier to remember than the docker ones. So I always create one. But no need to add it.

spoenemann commented 6 years ago

Thanks for the patch. Using yarn is not really necessary in the docker container, however, so I would rather stick with npm to avoid to install another tool.

spoenemann commented 6 years ago

Ah I see, we need yarn anyway because it's referenced in our package scripts :-/

I'll check again why your configuration didn't work for me.

spoenemann commented 6 years ago

I applied the switch to yarn and modified the Dockerfile a bit further in #196.