Animate addition and removal of elements

theia-ide / sprotty

A next-gen web-based graphics framework

Apache License 2.0

138 stars 23 forks source link

Animate addition and removal of elements #28

Closed JanKoehnlein closed 7 years ago

JanKoehnlein commented 7 years ago

The AddRemoveAnimationDecorator caused a race condition (#25) and has thus been removed. Find a better wa for those animations, not bypassing the event cycle.

JanKoehnlein commented 7 years ago

A pure CSS transition approach won't work as it will also fire when an element is moved, which is interpreted as a remove and an add.

spoenemann commented 7 years ago

The UpdateModelCommand will take care of creating appropriate animations.

spoenemann commented 7 years ago

Done.