theia-ide / sprotty

A next-gen web-based graphics framework
Apache License 2.0
138 stars 23 forks source link

Reconsider Command.isPushable #42

Closed JanKoehnlein closed 7 years ago

JanKoehnlein commented 7 years ago

We have implemented exceptional handling for SetBoundsCommands (isPushable returns false). The reason is that they are automatically fired and as such should be neutral to Undo/Redo. We should rather push them to the stack but

JanKoehnlein commented 7 years ago

We now have the notion of a system command. An example is the SetBoundsCommand. These commands should not be individually undoabl/redoable, and they should not break the chain of commands in an undo redo scenario. This means

I've added a few tests for this.