search

theia-ide / sprotty

A next-gen web-based graphics framework
Apache License 2.0
138 stars 23 forks source link

Get rid of all dependencies from base to features #68

Closed JanKoehnlein closed 7 years ago

JanKoehnlein commented 7 years ago

That currently includes 

> grep -r feature *  # manually filtered
intent/action-dispatcher.spec.ts:import { RedoAction, UndoAction } from "../../features/undo-redo/undo-redo"
intent/action-dispatcher.spec.ts:import { SetModelAction } from "../features/model-manipulation"
intent/action-dispatcher.spec.ts:import { MoveAction, MoveCommand } from "../../features/move/move"
intent/action-dispatcher.ts:import { SetModelAction, SetModelCommand } from '../features/model-manipulation';
intent/action-dispatcher.ts:import { RedoAction, UndoAction } from "../../features/undo-redo/undo-redo"
intent/command-stack.ts:import { HiddenBoundsUpdater } from '../../features/bounds/bounds-updater';
JanKoehnlein commented 7 years ago

I removed all but the undo/redo ones. I feel reluctant to move the undo/redo feature to base, as it is only needed for editors. The src/features module stands for optional functionality that should be enabled by adding the respective DI module. So undo/redo is fine there.