add vsx-registry to ci builds

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings

Apache License 2.0

1.04k stars 345 forks source link

add vsx-registry to ci builds #330

Closed emdfonseca closed 4 years ago

emdfonseca commented 4 years ago

What it does

Add @theia/vsx-registry dependency to latest and next package.json files of every app that is part of the CI pipeline (theia-cpp-docker theia-dart-docker theia-docker theia-full-docker theia-go-docker theia-java-docker theia-python-docker theia-rust-docker theia-swift-docker).

Closes #325

How to test

Trigger a build and let it finish. Everything builds without any issue.

Review checklist

[x] as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to review in accordance with the review guidelines

Signed-off-by: Emanuel Fonseca emdfonseca@gmail.com

emdfonseca commented 4 years ago

I updated the rust channel to "nightly-2020-04-10" in order to build successfully. If this needs to move out of the PR just let me know.

emdfonseca commented 4 years ago

Build tests frequently timeout on theia-rust. Build is running fine locally. Should we first merge #323 before approving this one?

marcdumais-work commented 4 years ago

Build tests frequently timeout on theia-rust. Build is running fine locally. Should we first merge #323 before approving this one?

done

marcdumais-work commented 4 years ago

@emdfonseca Thanks for the updates. Looks good to me.

The only one I am not sure is theia-rust: since it's now out of CI, one option is not to touch it in this PR. OTOH we hope to be able to fix CI it ASAP, so it may not hurt to include the vsx-registry extension even though it's not in CI ATM. WDYT?

emdfonseca commented 4 years ago

I'd accept this one cause it already adds value to the theia-apps repo without any issues. We can bring rust image back again later.

emdfonseca commented 4 years ago

I triggered the build again just because the status of the travis build was not updated in the PR. Is this normal or did I do something wrong?

marcdumais-work commented 4 years ago

I triggered the build again just because the status of the travis build was not updated in the PR. Is this normal or did I do something wrong?

I noticed that earlier too - I do not see that it's related to your PR.

marcdumais-work commented 4 years ago

I should probably have asked for the commits to be squashed into one, but too late now :)

marcdumais-work commented 4 years ago

@emdfonseca if you'd like to have a look at this follow-up PR . It builds-up from your update of the rust channel and fixes a couple of other things so that the image starts and vsx registry can be used from it.