search

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 345 forks source link

Add dart sdk to full image and install dart and flutter extensions to next image #369

Closed chrbayer closed 4 years ago

chrbayer commented 4 years ago

Please review. One drawback is that the dart SDK is installed to Dockerimage for stable and next image.

chrbayer commented 4 years ago

This fixes #368.

chrbayer commented 4 years ago

I have not added it to latest because it did not want to make this change for latest, the idea was to wait until next is getting latest. Do you think I should make the change in latest, too?

vince-fugnitto commented 4 years ago

I have not added it to latest because it did not want to make this change for latest, the idea was to wait until next is getting latest. Do you think I should make the change in latest, too?

@chrbayer don’t see why we wouldn’t add the functionality to both images, they both should have the proper functionality to make use of the new vscode extensions introduced by the pull-request.

Please be sure to properly squash your commits when you’re ready for a re-review :)

chrbayer commented 4 years ago

Thanks for the review :-) I have added the plugins to the latest image, too. The pull request should be complete now.

But there was a problem with downloading repgrep, I had the same problem with ci and my local builds... This seem to work again.

But now it fails Error: Cannot find module '../lib/theia' on next image... I had the same problem with this image before my changes, therefore I opened #371, see https://github.com/eclipse-theia/theia/issues/7974

chrbayer commented 4 years ago

This should be final now if nothing is found in the review.

marcdumais-work commented 4 years ago

But there was a problem with downloading repgrep, I had the same problem with ci and my local builds... This seem to work again.

Indeed - the latest ripgrep was momentarily broken. It's now fixed. See https://github.com/microsoft/vscode-ripgrep/issues/13

marcdumais-work commented 4 years ago

Thanks @chrbayer . @vince-fugnitto ready for a final review on this one?

chrbayer commented 4 years ago

@marcdumais-work Ready from my side. Thanks in advance!

vince-fugnitto commented 4 years ago

@chrbayer do you mind squashing your commits (into a single commit) so we can accept the changes? :)

chrbayer commented 4 years ago

@vince-fugnitto Of course, I will do it :-)

marcdumais-work commented 4 years ago

@chrbayer I think the commit message needs an update to reflect the current content. I suggest something like: [full] Add dart to latest and next images or simply: [full] Add dart

marcdumais-work commented 4 years ago

Awesome, thanks for the update @chrbayer

@vince-fugnitto Can you have another look, and if no further comments, merge?