Closed thegecko closed 4 years ago
Confirmed the build error is due to https://github.com/eclipse-theia/theia/issues/7974
I've tried pre-release for Mac and it did not work for me:
I've tried pre-release for Mac and it did not work for me:
The app isn't signed; it's expected, unfortunately.
The app isn't signed; it's expected, unfortunately.
The second error is not about singing. It does not start to me if I even override it.
The second error is not about singing.
I know; we have this error in the electron app since we ship with the VS Code extension support. It happens every time when the app start has failed. It is this: https://github.com/eclipse-theia/theia/issues/7113
It does not start to me if I even override it.
I do not understand this part, can you explain what do you many by even override it?
Travis CI job is now passing, this should be ready for review.
The second error is not about singing. It does not start to me if I even override it.
My interpretation: there is a way to bypass the check for signing, but the packaged app still does not work correctly
I think we'll need to update the README to really spell-out what this application is - an example desktop Theia application. I'll suggest some updates to the package.json as well for the same reason.
@thegecko One little thing before merging, if possible: it would be nice to squash the 3 commits into a single one.
Signed-off-by: thegecko rob.moran@arm.com
This PR introduces electron builds and publishing from TravisCI for the master branch.
I've already created a test publish of the installers here: https://github.com/theia-ide/theia-apps/releases/tag/v0.1.0
Note: These installer binaries are untested and currently unsigned. I will create a separate PR later to introduce signing for macOS and Windows.
Changes
theia-electron
project to uselatest
theia by default to be more stable for userstheia-electron
project to point at this repo (as it's used by electron-builder for publishing)Decisions to confirm
package.json
file which islatest
and notnext
nor an explicit version)theia-apps
repo and noteclipse-theia
Notes:
v1.2.0
.cc @akosyakov @marcdumais-work