theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 345 forks source link

Added Travis CI jobs to publish installers #370

Closed thegecko closed 4 years ago

thegecko commented 4 years ago

Signed-off-by: thegecko rob.moran@arm.com

This PR introduces electron builds and publishing from TravisCI for the master branch.

I've already created a test publish of the installers here: https://github.com/theia-ide/theia-apps/releases/tag/v0.1.0

Note: These installer binaries are untested and currently unsigned. I will create a separate PR later to introduce signing for macOS and Windows.

Changes

Decisions to confirm

Notes:

cc @akosyakov @marcdumais-work

thegecko commented 4 years ago

Confirmed the build error is due to https://github.com/eclipse-theia/theia/issues/7974

akosyakov commented 4 years ago

I've tried pre-release for Mac and it did not work for me:

Screenshot 2020-06-08 at 08 57 51 Screenshot 2020-06-08 at 08 58 28
kittaakos commented 4 years ago

I've tried pre-release for Mac and it did not work for me:

The app isn't signed; it's expected, unfortunately.

akosyakov commented 4 years ago

The app isn't signed; it's expected, unfortunately.

The second error is not about singing. It does not start to me if I even override it.

kittaakos commented 4 years ago

The second error is not about singing.

I know; we have this error in the electron app since we ship with the VS Code extension support. It happens every time when the app start has failed. It is this: https://github.com/eclipse-theia/theia/issues/7113

kittaakos commented 4 years ago

It does not start to me if I even override it.

I do not understand this part, can you explain what do you many by even override it?

thegecko commented 4 years ago

Travis CI job is now passing, this should be ready for review.

marcdumais-work commented 4 years ago

The second error is not about singing. It does not start to me if I even override it.

My interpretation: there is a way to bypass the check for signing, but the packaged app still does not work correctly

marcdumais-work commented 4 years ago

I think we'll need to update the README to really spell-out what this application is - an example desktop Theia application. I'll suggest some updates to the package.json as well for the same reason.

marcdumais-work commented 4 years ago

@thegecko One little thing before merging, if possible: it would be nice to squash the 3 commits into a single one.