search

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 346 forks source link

[full] Add Swift SDK to full image #373

Closed chrbayer closed 4 years ago

chrbayer commented 4 years ago

Add swift language tools to full image. If you want to use the swift REPL, these options have to be provided to docker: --cap-add=SYS_PTRACE --security-opt seccomp=unconfined

marcdumais-work commented 4 years ago

If you want to use the swift REPL, these options have to be provided to docker: --cap-add=SYS_PTRACE --security-opt seccomp=unconfined

We used to need the same or similar docker options, so that we could debug C/C++ programs in a container using GDB. However we recently noticed that it now works by default, without any special option. IIRC it was due to a docker change, re-classifying some options as being safe, and so they are now enabled by default.

Docker version I use: Docker version 19.03.2, build 6a30dfc

@chrbayer assuming you have a relatively recent docker version, could you confirm if the mentioned CLI options are still required for use of the swift REPL? If so a mention in the README would be good.

chrbayer commented 4 years ago

Hi @marcdumais-work ,

I'm using Docker version 19.03.11-ce, build 42e35e61f3 and I'm absolutely sure this options are still necessary for this version because it took me some time to google them and he REPL was crashing all the time. I will include them in the README.

marcdumais-work commented 4 years ago

Looks like the full latest image's Theia app was not responding during tests. I've restarted CI for that one only - I see no reason why this PR would cause this issue - probably just a glitch.

chrbayer commented 4 years ago

In that last time, I had often problems with the CI and had to start it all over until all images were built correctly...

marcdumais-work commented 4 years ago

In that last time, I had often problems with the CI and had to start it all over until all images were built correctly...

Unfortunately there's a know issue for contributors who submit PRs from their own fork - the Travis secure environment variables are not used then, for security reasons, and you'll often be unable to complete the build. The symptom usually an error related to vscode-ripgrep.

You've had a few contributions already - maybe I can give write access to the repo and then you can push your PR branch directly on this repo before creating a PR - that would avoid the issue.

If this sounds good to you, please ping me before opening your next PR and we can give it a shot.

marcdumais-work commented 4 years ago

Looks like the full latest image's Theia app was not responding during tests. I've restarted CI for that one only - I see no reason why this PR would cause this issue - probably just a glitch.

CI passed this time :+1: