json: replace json extension with vscode ext

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings

Apache License 2.0

1.04k stars 346 forks source link

json: replace json extension with vscode ext #383

Closed vince-fugnitto closed 4 years ago

vince-fugnitto commented 4 years ago

What it does

Fixes: https://github.com/theia-ide/theia-apps/issues/381

The following pull-request updates all latest docker images and electron builds to replace the now deprecated @theia/json extension with the vscode-builtin-json-language-features counterpart.

remove references of @theia/json (next was completed last month https://github.com/theia-ide/theia-apps/pull/380).
include vscode-builtin-json-language-features plugin.
removed unused resolutions.

How to test

The CI should be successful.

Review checklist

[x] as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

marcdumais-work commented 4 years ago

Thanks for this PR @vince-fugnitto . It might be a good opportunity to update built-in vscode.html-language-features to a recent version that has typescript bundled? i.e. :

https://open-vsx.org/api/vscode/html-language-features/1.47.3/file/vscode.html-language-features-1.47.3.vsix

Probably a good idea to quickly test that this new version still seems to work (not impossible that it might use new APIs). If that's the case we can go back to the next version we tested a week or two ago, that we now use in the main repo example app.

update: seems we're not using this extension in any example app here? We should probably have it at least in the examples that are suitable for JS/TS development, that often have a need for editing HTML. WDYT?

vince-fugnitto commented 4 years ago

Thanks for this PR @vince-fugnitto . It might be a good opportunity to update built-in vscode.html-language-features to a recent version that has typescript bundled? i.e. :

https://open-vsx.org/api/vscode/html-language-features/1.47.3/file/vscode.html-language-features-1.47.3.vsix

Probably a good idea to quickly test that this new version still seems to work (not impossible that it might use new APIs). If that's the case we can go back to the next version we tested a week or two ago, that we now use in the main repo example app.

update: seems we're not using this extension in any example app here? We should probably have it at least in the examples that are suitable for JS/TS development, that often have a need for editing HTML. WDYT?

@marcdumais-work I think its good we add vscode-builtin-html-language-features to all applications, should we file a separate issue to add it across all images and apps?

marcdumais-work commented 4 years ago

should we file a separate issue to add it across all images and apps?

:+1: that works for me