Closed vince-fugnitto closed 4 years ago
Until https://github.com/eclipse-theia/theia/pull/8315#pullrequestreview-462477628 is merged and released at the end of the month, the latest
full image will not have a working yang extension. We could add a quick chmod
after extensions download, to make plugins/<yangster>/extension/server/bin/yang-language-server
executable, as a temporary work-around.
Until eclipse-theia/theia#8315 (review) is merged and released at the end of the month, the
latest
full image will not have a working yang extension. We could add a quickchmod
after extensions download, to makeplugins/<yangster>/extension/server/bin/yang-language-server
executable, as a temporary work-around.
@marcdumais-work we also have the #386 error to worry about before we can officially make use of the extension properly.
I think theia-full@next
is failing because of @theia/rust
, which you take case-of in your other PR.
What it does
Fixes: #388
The following pull-request includes updates to yangster.
The
yangster-docker
image is removed since it makes use of the outdatedyangster
Theia-extension (which was replaced by theyang-vscode
vscode extension. Thetheia-full
image is updated to make use of the extension instead (so there is no need for the individual image anymore).How to test
The
yangster-docker
image is removed so verify that there are no longer any references toyangster
besides the new vscode extension. Thefull-image
should now support the new extension.The build currently fails due to #386
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com