theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 346 forks source link

yangster: remove 'yangster' image #390

Closed vince-fugnitto closed 4 years ago

vince-fugnitto commented 4 years ago

What it does

Fixes: #388

The following pull-request includes updates to yangster.

The yangster-docker image is removed since it makes use of the outdated yangster Theia-extension (which was replaced by the yang-vscode vscode extension. The theia-full image is updated to make use of the extension instead (so there is no need for the individual image anymore).

How to test

The yangster-docker image is removed so verify that there are no longer any references to yangster besides the new vscode extension. The full-image should now support the new extension.

The build currently fails due to #386

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

marcdumais-work commented 4 years ago

Until https://github.com/eclipse-theia/theia/pull/8315#pullrequestreview-462477628 is merged and released at the end of the month, the latest full image will not have a working yang extension. We could add a quick chmod after extensions download, to make plugins/<yangster>/extension/server/bin/yang-language-server executable, as a temporary work-around.

vince-fugnitto commented 4 years ago

Until eclipse-theia/theia#8315 (review) is merged and released at the end of the month, the latest full image will not have a working yang extension. We could add a quick chmod after extensions download, to make plugins/<yangster>/extension/server/bin/yang-language-server executable, as a temporary work-around.

@marcdumais-work we also have the #386 error to worry about before we can officially make use of the extension properly.

marcdumais-work commented 4 years ago

I think theia-full@next is failing because of @theia/rust, which you take case-of in your other PR.