repo: drop support for node 10 when building images - Githubissues

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings

Apache License 2.0

1.04k stars 345 forks source link

repo: drop support for node 10 when building images #391

Closed vince-fugnitto closed 4 years ago

vince-fugnitto commented 4 years ago

What it does

The following commit includes the following updates:

Bumping to Node 12\ The images and build are updated to make use of Node v12.18.3 (LTS) instead of Node 10 which will be dropped in upcoming releases. The bump in Node version is necessary for security updates, vscode extension compatibility and since it is the new LTS.

How to test

The CI should successfully pass (given that no other errors currently fail the build):

386

Review checklist

[x] as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

marcdumais-work commented 4 years ago

Wow, something seems wrong with CI. @vince-fugnitto do you know if these failures happen when you build and run the tests locally?

vince-fugnitto commented 4 years ago

I rebased the pull-request to pick up changes from #396.