search

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 345 forks source link

languages: drop '@theia/languages' #392

Closed vince-fugnitto closed 4 years ago

vince-fugnitto commented 4 years ago

What it does

Fixes: #387

The following pull-request removes the deprecated @theia/languages extension from both images and apps in favor of using vscode extensions to provide language-support.

How to test

Verify that CI passes successfully.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

marcdumais-work commented 4 years ago

I think we'll need to merge https://github.com/theia-ide/theia-apps/pull/393 before the C/C++ related images can build correctly. We have a circular dependency - we'll need to merge one or the other on faith :)