search

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 345 forks source link

repo: cleanup and remove unnecessary images #402

Open vince-fugnitto opened 4 years ago

vince-fugnitto commented 4 years ago

Description

The framework has moved towards using vscode extensions to provide language and debugging features, and consequently it should be possible to remove unnecessary images which only differ in the vscode extensions they include.

Motivation

  1. less maintenance overall (fewer images to maintain and manage).
  2. theia-full already covers most languages (no need for individual images for a specific language).
  3. the difference between images is minimal (main difference is vscode extensions included).
  4. the images are used for reference and are not official, those who wish to create their own images can be inspired by them and they are present in the history of the repository.

Potentially Remove:

cc @theia-ide/core

marcdumais-work commented 4 years ago

the difference between images is minimal (main difference is vscode extensions included).

I would rather say that the difference between the various Theia applications, made available in our variuos images, is minimal. So we can consider keeping some images if they bring something "special" vs theia-full, even if their Theia app is not special. e.g. theia-rust is different enough that it may be worthwhile to keep it.

vince-fugnitto commented 4 years ago

I wanted to try and discuss what we should try to keep and what can be removed, are there images that we are particularly interested in maintaining besides theia-docker and theia-full-docker.

vince-fugnitto commented 4 years ago

The theia-java should be removed, it requires a lot of changes and currently uses an old deprecated base java8 image. In addition, the theia-full image already makes use of java (11) so there is no need for the individual image.

stale[bot] commented 4 years ago

This contribution has been automatically marked as stale due to inactivity, and it will be closed if no further activity occurs. Thank you for contributing to Theia!