search

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 346 forks source link

repo: cleanup linting errors #410

Closed vince-fugnitto closed 3 years ago

vince-fugnitto commented 4 years ago

Description

There are some minor linting errors reported during the build which we can fix:

1.20s$ eclint check "**/*" || echo "Warning! Formatting errors encountered..."
theia-electron/package.json
    - 17:01 invalid indent size: 10, expected: 12 (EditorConfig indent_size https://goo.gl/QtGB8R)
    - 19:01 invalid indent size: 10, expected: 12 (EditorConfig indent_size https://goo.gl/QtGB8R)
theia-full-docker/settings.json
   - 03:01 expected final newline

The theia-full-docker/settings.json file should be removed in favor of specifying the default values directly in the corresponding package.json:

https://github.com/theia-ide/theia-apps/blob/840ceaf00c41b387793f1849898db1a688083e6e/theia-full-docker/latest.package.json#L7-L10

https://github.com/theia-ide/theia-apps/blob/840ceaf00c41b387793f1849898db1a688083e6e/theia-full-docker/next.package.json#L7-L10

cc @DukeNgn