theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 346 forks source link

[full] Disable .NET SDK Telemetry and .NET welcome message #417

Closed DucNgn closed 3 years ago

DucNgn commented 3 years ago

What it does:

Note: The following message from telemetry will still be in the log. It is a default setting from Microsoft. See this

Telemetry

The .NET Core tools collect usage data in order to help us improve your experience. The data is anonymous and doesn't include command-line arguments. The data is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell. Read more about .NET Core CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry

Signed-off-by: Duc Nguyen duc.a.nguyen@ericsson.com

vince-fugnitto commented 3 years ago

@marcdumais-work I wanted to find a way to remove the message, I had thought that DOTNET_SKIP_FIRST_TIME_EXPERIENCE would remove it completely looking at the discussion in the issue linked.

marcdumais-work commented 3 years ago

@marcdumais-work I wanted to find a way to remove the message, I had thought that DOTNET_SKIP_FIRST_TIME_EXPERIENCE would remove it completely looking at the discussion in the issue linked.

Because we still see the message in the build log, you're concerned that maybe telemetry is still enabled?

vince-fugnitto commented 3 years ago

@marcdumais-work I wanted to find a way to remove the message, I had thought that DOTNET_SKIP_FIRST_TIME_EXPERIENCE would remove it completely looking at the discussion in the issue linked.

Because we still see the message in the build log, you're concerned that maybe telemetry is still enabled?

It gives the impression it is still there yes, unfortunately there is no way to verify besides testing and verifying the outgoing messages.

marcdumais-work commented 3 years ago

BTW, MS sometimes have a strange idea of what "disabling telemetry" means. IIRC in some vscode extensions, disabling telemetry, it still connects to telemetry servers and sends reports telemetry, but only to let them know it's disabled :)

vince-fugnitto commented 3 years ago

BTW, MS sometimes have a strange idea of what "disabling telemetry" means. IIRC in some vscode extensions, disabling telemetry, it still connects to telemetry servers and sends reports telemetry, but only to let them know it's disabled :)

The change was also controversial for .NET (when they suddenly made telemetry on by default), and the fact they chose to be opt-out instead of opt-in.

vince-fugnitto commented 3 years ago

I think we can confirm by running the command:

dotnet -d

Hopefully we will have:

Telemetry is: Disabled
vince-fugnitto commented 3 years ago

I think we can confirm by running the command:

dotnet -d

Hopefully we will have:

Telemetry is: Disabled

I confirmed that the env variable worked in the draft pull-request #420 https://travis-ci.com/github/theia-ide/theia-apps/jobs/386410765#L11025

Step 31/55 : RUN dotnet -d
 ---> Running in a86e9d805e4d
Telemetry is: Disabled