search

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 346 forks source link

full: remove .net message #418

Closed vince-fugnitto closed 3 years ago

vince-fugnitto commented 3 years ago

Description

Removes the welcome message for .NET based on the documentation.

The .NET Core SDK displays text similar to the following when you first run one of the .NET Core CLI commands (for example, dotnet build). Text may vary slightly depending on the version of the SDK you're running. This "first run" experience is how Microsoft notifies you about data collection.

To disable this message and the .NET Core welcome message, set the DOTNET_NOLOGO environment variable to true. Note that this variable has no effect on telemetry opt out.

How to Test

The .NET welcome message should not be outputted to the build log:

Welcome to .NET Core!
---------------------
Learn more about .NET Core: https://aka.ms/dotnet-docs
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli-docs
Telemetry
---------
The .NET Core tools collect usage data in order to help us improve your experience. The data is anonymous and doesn't include command-line arguments. The data is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.
Read more about .NET Core CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

vince-fugnitto commented 3 years ago

I don't really understand what is going on unfortunately, the opt-out should not display the message. Based on the documentation, opting out of the message has no effect when telemetry is opt-out.

To disable this message and the .NET Core welcome message, set the DOTNET_NOLOGO environment variable to true. Note that this variable has no effect on telemetry opt out.