electron: adjust the engines field

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings

Apache License 2.0

1.04k stars 345 forks source link

electron: adjust the engines field #422

Closed vince-fugnitto closed 3 years ago

vince-fugnitto commented 3 years ago

Description

The commit updates the engines field for both electron applications so it is aligned with upstream:

adjusts the engines field for the theia-electron app
adjusts the engines field for the theia-cpp-electron app

How to Test:

build and package the theia-electron application
the application should successfully start

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

marcdumais-work commented 3 years ago

Good idea - this will help guide people who try to self-build these apps, while not being aware of the exact nodeand yarn version required to do so.

vince-fugnitto commented 3 years ago

Looks like I need to adjust the CI a bit (failing for the electron builds).

marcdumais-work commented 3 years ago

Looks like I need to adjust the CI a bit (failing for the electron builds).

Up-to you if you want to do so in the same PR.

vince-fugnitto commented 3 years ago

@marcdumais-work fine to merge, or should I squash?