Closed paul-marechal closed 3 years ago
I built and tested the PR on my machine. Everything works well 👍
I think we can wait a bit, and try to merge the following PR first, that touches the full image, since I think it will be easier than the other way around: https://github.com/theia-ide/theia-apps/pull/425
I can drop the full image change commit, the other images are not affected right?
I can drop the full image change commit, the other images are not affected right?
Do you mean to drop the full image from the current PR, merge the remaining changes immediately, and bring back the full image changes in another PR, after #425 is merged?
@marcdumais yes.
@DukeNgn Since you tested this PR, I added you as a reviewer. If you're satisfied, you can add your official approval, now.
Finish splitting the last Dockerfiles to build Theia in its own image.