search

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 345 forks source link

split images: cpp, go and rust #428

Closed paul-marechal closed 3 years ago

paul-marechal commented 3 years ago

Finish splitting the last Dockerfiles to build Theia in its own image.

DucNgn commented 3 years ago

I built and tested the PR on my machine. Everything works well 👍

marcdumais-work commented 3 years ago

I think we can wait a bit, and try to merge the following PR first, that touches the full image, since I think it will be easier than the other way around: https://github.com/theia-ide/theia-apps/pull/425

paul-marechal commented 3 years ago

I can drop the full image change commit, the other images are not affected right?

marcdumais-work commented 3 years ago

I can drop the full image change commit, the other images are not affected right?

Do you mean to drop the full image from the current PR, merge the remaining changes immediately, and bring back the full image changes in another PR, after #425 is merged?

paul-marechal commented 3 years ago

@marcdumais yes.

marcdumais-work commented 3 years ago

@DukeNgn Since you tested this PR, I added you as a reviewer. If you're satisfied, you can add your official approval, now.