search

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 345 forks source link

bump yarn env to 1.22.5 for theia-full and theia-cpp-docker #433

Closed cyrilcros closed 3 years ago

cyrilcros commented 3 years ago

Closing https://github.com/theia-ide/theia-apps/issues/432 This updates the frozen YARN_VERSION used in a few Dockerfiles. EDIT: also the copying/ chown’ing of /home/theia are now combined for theia-full; that should speed up build time.

cyrilcros commented 3 years ago

FYI 1.22.5 seems to fail, 1.21.0 may be okay when building the Dockerfile on my own computer. I will update the title / the push request once I figure it out.

cyrilcros commented 3 years ago

@vince-fugnitto : changing the theia-full Dockerfile to use 1.22.5 for yarn works up to a point on my computer (the Dockerfile has some issues after installing Dart). However, this near steps 48 of the build, whereas Travis fails at step 16 with the theia build process. I notice that Travis runs most of the tests under Node 10 despite the NODE_VERSION environment variable using a node 12 version. Is that an issue?

vince-fugnitto commented 3 years ago

I notice that Travis runs most of the tests under Node 10 despite the NODE_VERSION environment variable using a node 12 version. Is that an issue?

It's not, the node version used by travis is simply to execute the test suite (which is a basic sanity check to determine the application starts and has the proper views), and is separate than the actual images and building the application. I restarted the Travis build, ripgrep fails to download occasionally due to forks and not having the proper GitHub rate tokens.

cyrilcros commented 3 years ago

Thanks, the theia-full now ran to completion. Can you please rerun all the other failed tests? Thanks!

cyrilcros commented 3 years ago

@vince-fugnitto I now have the Docker image running at home (Dockerhub link) and everything is fine. I got 2 last failing Travis CI tests, can you run them again? Thanks

marcdumais-work commented 3 years ago

Hi @cyrilcros

@vince-fugnitto I now have the Docker image running at home (Dockerhub link) and everything is fine. I got 2 last failing Travis CI tests, can you run them again? Thanks

No worries - one of these always fails (needsto be removed) and you have not modified these images in your PR, in any case.

vince-fugnitto commented 3 years ago

LGTM, thanks @cyrilcros . @vince-fugnitto any pending comment(s)?

It looks fine to me :)

marcdumais-work commented 3 years ago

Thanks for this contribution, @cyrilcros. Merging.