Patch: Fix build fails in some images - Githubissues

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings

Apache License 2.0

1.04k stars 345 forks source link

Patch: Fix build fails in some images #447

Closed DucNgn closed 3 years ago

DucNgn commented 3 years ago

What it does

The workflow is failing for some images. This PR attempts to address the issue and also fix potential problems by:
- Change ubuntu-latest to ubuntu-18.04 as the latest version soon will be 20.04
- Fix wrongly passing GITHUB_TOKEN in build_container
- Fix node-gyp error by attempting to call node-gyp install first (https://github.com/nodejs/node-gyp/issues/1780#issuecomment-503976718)

How to test

The CI should pass Note: The CI may fail for rust images since it's an existing issue with racer. This PR doesn't cover the fix for it.

Signed-off-by: Duc Nguyen duc.a.nguyen@ericsson.com

paul-marechal commented 3 years ago

Do you know if the theia-full failure can be fixed? Maybe an outdated url?

DucNgn commented 3 years ago

@marechal-p I think it's a connectivity issue within GitHub actions (https://github.com/theia-ide/theia-apps/pull/447/checks?check_run_id=1513386667#step:6:17857), I'm restarting the build to see if it's still failing.