search

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 345 forks source link

CI: Use login-action to log in DockerHub #458

Closed DucNgn closed 3 years ago

DucNgn commented 3 years ago

What it does

Closes #454

How to test

Signed-off-by: Duc Nguyen duc.a.nguyen@ericsson.com

marcdumais-work commented 3 years ago

Yes, please do.

On Fri, Jan 22, 2021, 08:51 Vincent Fugnitto notifications@github.com wrote:

@vince-fugnitto commented on this pull request.

In .github/workflows/ci-cd.yml https://github.com/theia-ide/theia-apps/pull/458#discussion_r562643553:

@@ -129,3 +129,4 @@ jobs: max_attempts: 3 retry_on: error command: docker push "theiaide/${{ matrix.IMAGE_NAME }}"

I'm worried about the docker push command not being able to read the secrets, should we move to the official docker-push action?:

steps:

  - name: Check Out Repo
    uses: actions/checkout@v2

  - name: Login to Docker Hub
    uses: docker/login-action@v1
    with:
      username: ${{ secrets.DOCKER_HUB_USERNAME }}
      password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }}

  - name: Set up Docker Buildx
    id: buildx
    uses: docker/setup-buildx-action@v1

  - name: Build and push
    id: docker_build
    uses: docker/build-push-action@v2
    with:
      context: ./
      file: ./Dockerfile
      push: true
      tags: ushamandya/simplewhale:latest

  - name: Image digest
    run: echo ${{ steps.docker_build.outputs.digest }}

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/theia-ide/theia-apps/pull/458#pullrequestreview-574275275, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGEOMR2FGIB4PMN3EIB36KTS3F7FPANCNFSM4WOQDASA .

marcdumais-work commented 3 years ago

@vince-fugnitto I'm ok trying this. Are you ok to merge as-is?

vince-fugnitto commented 3 years ago

@vince-fugnitto I'm ok trying this. Are you ok to merge as-is?

@marcdumais-work fine with me :smile: