search

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 346 forks source link

New Language Support: Haskell #478

Closed lapplislazuli closed 3 years ago

lapplislazuli commented 3 years ago

Hi there 👋 ,

I would currently like to use Theia with Haskell. Is this something you accept PR's for? I'd basically reproduce the cpp image just with the haskell compiler and tools in the later parts.

Is there anything else (except the contribution guidelines) that I should be aware of?

vince-fugnitto commented 3 years ago

@lapplislazuli thank you for your interest in the project :+1:

We have been moving towards having less images overall (https://github.com/theia-ide/theia-apps/issues/402) since it increases maintenance and the images are solely for example purposes (and also to test CI against the main repository). Given that the haskell image is likely not so complicated or different than other images I'm not sure it adds much value at this time to include it in the repository as an example for others. You can however inspire yourself from other images to develop and use it yourself :smiley:

cc @marcdumais-work

vince-fugnitto commented 3 years ago

Please see also:

Perhaps including it in theia-full would be an alternative to a completely new image.

marcdumais-work commented 3 years ago

Perhaps including it in theia-full would be an alternative to a completely new image.

Yes, I think so. @lapplislazuli would you be interested in adding Haskell support to the theia-full image? If so, please go ahead.

lapplislazuli commented 3 years ago

Good Morning,

Thanks for the quick responses 😄 I first wanted to ask before I start a PR out of the blue. Keeping your maintenance low is something I can understand.

I think I'll first do a Theia-Haskell similar to the CPP image (privately), and then make a PR for the Theia Full 👍