search

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 344 forks source link

[misc images] add new Theia runtime dependency: libsecret #482

Closed marcdumais-work closed 3 years ago

marcdumais-work commented 3 years ago

It's required starting with Theia 1.15.0. It may still be missing in some images

Also updared the GPG key servers that were interfering with the build of a couple of imafges lately.

Signed-off-by: Marc Dumais marc.dumais@ericsson.com

marcdumais-work commented 3 years ago

and the CI is passing

Note: our conservative build system works against us here. Images that I have not changes are not rebuilt, which hides the fact they need update. E.g. the Python image. The nightly build will show the truth :)

vince-fugnitto commented 3 years ago

Note: our conservative build system works against us here. Images that I have not changes are not rebuilt, which hides the fact they need update. E.g. the Python image. The nightly build will show the truth :)

@marcdumais-work we can execute the workflow manually on any branch, so this should give us the best representation:

I ran the ci-cd wofkflow on the libsecret branch which should test all images.

marcdumais-work commented 3 years ago

I ran the ci-cd wofkflow on the libsecret branch which should test all images.

Thanks! Can you restart it? I have just added the library for Python and Swift. On second thought, let's keep it and find-out if other images need update - we can ignore Python and Swift in favor of the latest CI run on the PR.

marcdumais-work commented 3 years ago

I made a small correction to the Python image and forced-push. Should be ok now.

vince-fugnitto commented 3 years ago

@marcdumais-work if you're curious on how to run the workflow manually, I included a small video:

https://user-images.githubusercontent.com/40359487/123993892-d7952980-d99a-11eb-99d1-8b2bdc110b7c.mp4

marcdumais-work commented 3 years ago

CI is passing - I'll squash and if everything good, should be ready to merge