search

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 346 forks source link

theia-docker: add `libsecret-dev` dependency #488

Closed vince-fugnitto closed 3 years ago

vince-fugnitto commented 3 years ago

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

marcdumais-work commented 3 years ago

@vince-fugnitto I tried to add libsecret-dev like you did here, but keeping it as runtime dependency too, and it seems to work: https://github.com/theia-ide/theia-apps/pull/489

Not sure what changed, but ~1 month ago, I think we only needed it at runtime.

vince-fugnitto commented 3 years ago

@vince-fugnitto I tried to add libsecret-dev like you did here, but keeping it as runtime dependency too, and it seems to work:

489

Not sure what changed, but ~1 month ago, I think we only needed it at runtime.

It’s very weird, I’ll have to investigate more tomorrow when I get a chance. For example, it worked yesterday on this pull-request: https://github.com/theia-ide/theia-apps/pull/487.

vince-fugnitto commented 3 years ago

Closing wip in favor of #489.