search

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 344 forks source link

Fix full, cpp-docker and rust images, cpp-electron app #495

Closed marcdumais-work closed 2 years ago

marcdumais-work commented 2 years ago

Fix theia-full, theia-cpp and theia-rust images

By switching to extension cdt-gdb-vscode instead of using @theia/cpp-debug.

In addition, transition theia-full to use the new vscode built-in extensions pack, instead of listing indivbidual extensions.

Fixes #494

marcdumais-work commented 2 years ago

@vince-fugnitto I have rebased on master so we can benefit from your recent test suite improvements, for the CI of this PR.

marcdumais-work commented 2 years ago

Do we not want to pin typescript-language-features? Next month (for latest) I believe the API version will be bumped and for next it already has been.

In case others are interested, we discussed this offline and concluded that we should not have to pin this plugin.

marcdumais-work commented 2 years ago

@vince-fugnitto I have simplified the PR, only addressing the failing images and only switching to the build-ins extension pack for the full image. Can you have another look?

marcdumais-work commented 2 years ago

I think the failure for theia@latest is unrelated to this PR.