theia-ide / theia-sprotty-example

An example application integrating Sprotty views with Theia
Apache License 2.0
18 stars 5 forks source link

[DSL] selection in step blocks should ignore white space #8

Open marcdumais-work opened 7 years ago

marcdumais-work commented 7 years ago

I think I have seen this issue in sprotty a while back, it was fixed and now seem to be back. When I move the cursor in the DSL, it I put it on white space, for example beginning of a line within a step block, the diagrams do not react. They react only if I move to the first word of the line (ex: just before the "c" of "core"). I think it should ignore white space and react on the line where the cursor is.

JanKoehnlein commented 7 years ago

I copied the code from sprotty-web but with little effect: We currently use the language service getDocumentHighlights to detect caret position changes and that service is not called by the client when the caret is moved to a whitespace. So the rest of the work to be done here is fixing https://github.com/theia-ide/theia/issues/164