search

theia-ide / theia-vscodecov

Test VS Code API coverage against Theia for any VS Code extension
4 stars 4 forks source link

extensions.onDidChange not being reported as used for vscode-java #1

Closed tsmaeder closed 5 years ago

tsmaeder commented 5 years ago

When I run the tool agains vscode-java (https://github.com/redhat-developer/vscode-java/), the API call "extensions.onDidChange" is not being picked up. My suspicion is that it is not being picked up because vscode-java imports the extensions namespace like so:

import { ..., extensions ,...} from 'vscode-java';

Since this seems like perfectly valid code, we might be missing lots of API usages right now.

akosyakov commented 5 years ago

@tsmaeder it should be fixed by https://github.com/theia-ide/theia-vscodecov/commit/b22c487c6cf13da72edf932a8b339440cf1c42b7 Could you try?

It respects property access syntax now.

tsmaeder commented 5 years ago

looks much better.

 "missingSymbols": [
    "\"vscode\".Extension.extensionPath",
    "\"vscode\".QuickInput.show",
    "\"vscode\".QuickPick",
    "\"vscode\".QuickPick.items",
    "\"vscode\".QuickPick.onDidChangeSelection",
    "\"vscode\".QuickPick.onDidHide",
    "\"vscode\".QuickPick.placeholder",
    "\"vscode\".QuickPick.show",
    "\"vscode\".QuickPick.step",
    "\"vscode\".QuickPick.title",
    "\"vscode\".QuickPick.totalSteps",
    "\"vscode\".extensions.onDidChange",
    "\"vscode\".window.createQuickPick"
  ],