search

theia-ide / yangster-electron

Bundled Yangster electron application
Apache License 2.0
118 stars 32 forks source link

generated gitignore is too strict #33

Open duncdrum opened 3 years ago

duncdrum commented 3 years ago

When using this template the generated .gitignore contains 

webpack.config.js
yarn.lock

neither file should be ignored. The first is for user modifications in combination with gen-webpack.config.js, so it makes no sense to have it ignored (while still being checked into the git tree) OOTB.

As for yarn.lock the recommendation is clearly to not have it ignored either.

While it is easy for users to manually unignore both files, it should be a simple fix to simply remove them from the .gitignore here to save everyone the hassle.

see https://github.com/evolvedbinary/fusion-studio/issues/93 see https://github.com/eclipse-theia/theia-blueprint/issues/134