GH-61: Implemented the semantic highlighting for YANG.

theia-ide / yangster

Yangster is a YANG IDE based on Theia

Apache License 2.0

42 stars 17 forks source link

GH-61: Implemented the semantic highlighting for YANG. #65

Closed kittaakos closed 6 years ago

kittaakos commented 6 years ago

Closes: #61.

This is the counterpart PR of https://github.com/theia-ide/yang-lsp/pull/143.

The PR contains the followings:

Syntax coloring is done by TM instead of monarch.
Added --mode development for faster builds.
Added @theia/file-search and @theia/search-in-workspace to the application.
Added the semantic highlighting feature Yang language client.

Also: Closes #63.

Signed-off-by: Akos Kitta kittaakos@typefox.io

kittaakos commented 6 years ago

@JanKoehnlein, are you OK with the changes? I would like to wrap up this PR with the corresponding LS changes. Thanks!

kittaakos commented 6 years ago

Thank you for the review. I resolve the conflicts and start a new build soon.

kittaakos commented 6 years ago

I had to update to next Theia by wiping and regenerating the yarn.lock.
Also, I had to change the type-definition of monaco.

kittaakos commented 6 years ago

I need to revisit this. The TM coloring does not work. Perhaps there was a change in Theia.

kittaakos commented 6 years ago

It is done; we have the highlighted statements on the top of the syntax coloring in the editor. Unfortunately, Theia has a few limitations. Those will be addressed and tackled in Theia. I am merging this.