Closed marcdumais-work closed 5 years ago
When building we get a mix of "next" and "latest" theia extensions. It looks-like we end-up pulling theia-sprotty
from npm instead of using the local one, that correctly has @theia
"next" dependencies.
from yangster/node_modules/theia-sprotty/package.json
:
"@theia/core": "latest",
"@theia/editor": "latest",
"@theia/filesystem": "latest",
"@theia/languages": "latest",
"@theia/monaco": "latest",
from yangster/theia-sprotty/package.json
:
"@theia/core": "next",
"@theia/editor": "next",
"@theia/filesystem": "next",
"@theia/languages": "next",
"@theia/monaco": "next",
Related to this recent commit I think: https://github.com/theia-ide/yangster/commit/6ee02d79d24b5326f83ba28ba373107b8fe91065
Confirmed: if I roll-back the last couple of commits, then "next" build correctly. Shall we revert to 90d9d8c2ef3a6d291e59cf95499157153b5c02fa
and publish a new version?
The problem is that theia-sprotty:0.1.20 depends on theia:latest. So for next builds, we cannot use 0.1.20 but have to use theia-sprotty:next. I think, we have to adapt the theia-version.sh script to also change this. We should convert it to JS anyway, such that it runs on all OSs.
Strangely, everything compiled well on my local repo, and I could as well do a latest release and a new next build. I had to checkout a fresh clone to reproduce it.
As the repo's master should always refer to next, I'll change that. The current latest build should be OK. Would be nice if you checked that.
BTW, sprotty has moved to Eclipse, and we should refactor yangster to use the eclipse versions of sprotty and sprotty-theia.
It's a mess. I tried for several hours now, but I cannot get the next build running, because theia-sprotty@next is completely messed up on npm. It's not worth fixing as the Eclipse package will have a different name anyway.
I propose to leave it as is and only produce latest releases until we port yangster to Eclipse sprotty.
Thanks for giving this a good try, @JanKoehnlein .
I propose to leave it as is and only produce latest releases until we port yangster to Eclipse sprotty.
+1
the Eclipse package will have a different name anyway
Will you rename the package by choice or is it mandated by the Foundation? I was wondering if we will have to rename the @theia
packages of the main repo, once we move in the Foundation.
Hi Marc, we will not have to rename the packages. That would be a big mess.
btw. I fixed the master build of this repo, today. So it works again. But I think we should keep this ticket open, as the big work (migrating everything to the latest sprotty) is still todo.
Oh, I see you created a separate ticket. So we can close this one.
I fixed the master build of this repo, today. So it works again
Thanks!
There will be a release of Theia tomorrow, where something close to the current "next" version will become "latest", presumably breaking also "latest" of yangster.