search

theia-ide / yangster

Yangster is a YANG IDE based on Theia
Apache License 2.0
42 stars 17 forks source link

theia-yang-extension@next pull specific version of @theia/core #85

Open marcdumais-work opened 4 years ago

marcdumais-work commented 4 years ago

The most recent next version of the yangster demo app under theia-ide/theia-apps has not been passing CI for about a month. Investigating, I noticed that theia-yang-extension@next pulls a specific version of @theia/core, resulting in duplication of that extension and rendering the application unable to start:

theia-yang-extension@0.2.0-next.5822afd8 (latest "next"): "dependencies": { "@theia/core": "0.7.0-next.e147cf39", "sprotty": "next", "sprotty-theia": "next", "yang-sprotty": "0.3.0-next.5822afd8" }

Looking on dockerhub, this seems to be the latest time this image built : https://hub.docker.com/layers/theiaide/yangster/0.15.0-next.2eb1cfce/images/sha256-9c4e5a1cf8f4ef0b577d86328b139887b351eec08bf1a19b9beace69ce8d59d2

In that one (theia-yang-extension@0.2.0-next.b049d080), the dependency is :

"dependencies": { "@theia/core": "next", "sprotty": "next", "sprotty-theia": "next", "yang-sprotty": "0.3.0-next.b049d080" },

which works fine.

So I think theia-yang-extension@next should be published with the @theia/core dependency pointing to generic next.

JanKoehnlein commented 4 years ago

I'd propose to remove yangster from the CI build of theia-apps.

We don't have the resources to maintain compatibility with all versions of Theia and Sprotty, so we'll head for one stable build with fixed versions and freeze the yarn.lock file. It doesn't make sense to continuously build against newer versions if nobody is going to fix issues.

marcdumais-work commented 4 years ago

I'd propose to remove yangster from the CI build of theia-apps.

Ok with me. We'll also remove theia-yang-extension from the theia-full:next image, since we want to keep CI running for that image.

We don't have the resources to maintain compatibility with all versions of Theia and Sprotty, so we'll head for one stable build with fixed versions and freeze the yarn.lock file. It doesn't make sense to continuously build against newer versions if nobody is going to fix issues.

+1.

To confirm I understand correctly, this does not preclude future punctual updates to the yangster-related extensions, just that it will not happen routinely, to keep-up with latest Theia?