theiagen / public_health_bacterial_genomics

GNU Affero General Public License v3.0
26 stars 14 forks source link

add optional task for shigeifinder w/ reads as input; update default docker for both shigeifinder & shigatyper #202

Closed kapsakcj closed 1 year ago

kapsakcj commented 1 year ago

Setting as a draft until the staphb/shigeifinder:1.3.3 docker image is available

Ready for review!

Summary of code changes in PR:

testing

I have tested both PE and SE samples on >100 Shigella & E. coli samples in Terra and they have ran as expected. TheiaProk_PE test on various Shigella and a few EIEC's TheiaProk_SE test on various Shigella and a few EIEC's. Can ignore the 1 failure as it's related to shigatyper and not shigeifinder TheiaProk_PE test on 73 E. coli

kevinlibuit commented 1 year ago

Everything looking solid. Running one more test with default merlin magic params ( (i.e. call_shigeifinder_reads_input = false) for sanity's sake.

Will merge pending a successful run.