Closed kapsakcj closed 1 year ago
@cimendes when you get a chance can you please give the code a look over & test in Terra on some samples? I would like to get this PR merged before we merge PR #213
I tested the branch on 50 S. aureus successfully on terra (https://app.terra.bio/#workspaces/theiagen-validations/Theiagen_Mendes_Sandbox/job_history/0c754c08-5955-49aa-83c5-2bae53ade521, one failed due to an unrelated issue), and obtained the expected output columns. :) LGTM! I think we can go ahead and merge this one.
merge away! Thank you for testing!
@kapsakcj can I delete the branch?
Opened a separate branch to ease testing on Terra without disrupting anyone currently using the
cjk-saureus-subwf
branch.This PR adds the tool
agrvate
to the merlin magic subworkflow for any samples identified as "Staphyloccus aureus" by GAMBIT.Setting as a draft until I'm done testing in TerraTesting in Terra is complete, I'm comfortable merging this into thecjk-saureus-subwf
dev branch.Tested both TheiaProk_Illumina_SE: https://app.terra.bio/#workspaces/cdph-terrabio-taborda-manual/curtis_sandbox/job_history/058e88f0-df97-4094-a7e7-08a312d959a2
and TheiaProk_Illumina_PE (failures here are due to test data, not code changes): https://app.terra.bio/#workspaces/cdph-terrabio-taborda-manual/curtis_sandbox/job_history/83b43378-ae76-488d-a70f-5f0b96ec9df2
Changes
tasks/species_typing/task_agrvate.wdl
disk_size
input var to50
, don't need much spaceecho
agrvate
command to always use mummer with-m
option since usearch is not available in the container (due to strict redistribution rules)cpu
now uses input variablecpu
tasks/utilities/task_broad_terra_tools.wdl
agrvate_docker_image
for when new versions are releasedI have NOT adjusted CI, so after merging I expect to see some CI failures on the other PR. Currently the CI is setup to only run on pull requests to
main
branch and not to others, so we can fix the CI stuff on PR #213