theiagen / public_health_bioinformatics

Bioinformatics workflows for genomic characterization, submission preparation, and genomic epidemiology of pathogens of public health concern.
GNU General Public License v3.0
33 stars 15 forks source link

virulencefinder is not triggered for Shigella sonnei #273

Open kapsakcj opened 7 months ago

kapsakcj commented 7 months ago

:bug:

:pencil: Describe the Issue

It seems that due to the way that merlin_tag's are assigned by GAMBIT and the way that the taxon-specific tasks are configured in the merlin_magic subworkflow, samples identified as Shigella sonnei (gambit_predicted_taxon output) are not run through virulence finder.

:repeat: How to Reproduce

Run a Shigella sonnei sample through a TheiaProk workflow v1.2.1 (likely Illumina PE workflow)

:fishing_pole_and_fish: Expected Behavior

Expect virulencefinder to be run on all Escherichia and Shigella species.

:floppy_disk: Version Information

All, but tested with v1.2.1

:information_source: Additional Information

I think we need to be very careful about making these adjustments and ensure that merlin_tag's are set in the GAMBIT task properly & that the merlin_magic subworkflow is updated to allow for Shigella sonnei to also be run through virulencefinder

There are some other similar bugs like this that need to be addressed. Would be good to open these as separate issues & PRs unless we can do one big sweeping PR that fixes many of these issues.

kapsakcj commented 7 months ago

For this particular issue, we could resolve this issue by updating this conditional: https://github.com/theiagen/public_health_bioinformatics/blob/ab5441926e0a62d60996871639d2f9826ebee052/workflows/utilities/wf_merlin_magic.wdl#L138