theiagen / public_health_bioinformatics

Bioinformatics workflows for genomic characterization, submission preparation, and genomic epidemiology of pathogens of public health concern.
GNU General Public License v3.0
34 stars 16 forks source link

TheiaCoV_ONT: prevent failure by coercing files into strings #288

Closed sage-wright closed 7 months ago

sage-wright commented 7 months ago

Closes #270

:hammer_and_wrench: Changes Being Made

To prevent workflow failure when read screening fails, this PR coerces the File assembly_fasta output into a String. Outputs behave the same on Terra, but workflow failure no longer will occur.

Also, some redundant ? were removed

Impacted Workflows/Tasks

:brain: Context and Rationale

"" cannot be evaluated as a File, but a File can be evaluated as a String.

:clipboard: Workflow/Task Steps

No change

Inputs

No change

Outputs

No new outputs

Impacted Outputs

String assembly_fasta

:test_tube: Testing

Locally

Terra

No original failures (before change) in read screen: https://app.terra.bio/#workspaces/cdc-terra-resources/Theiagen_Wright_SC2_Sandbox/job_history/17bbd163-1949-431f-a745-b4d5c9d15193

Original failures (before change) in read screen: https://app.terra.bio/#workspaces/cdc-terra-resources/Theiagen_Wright_SC2_Sandbox/job_history/4443d283-9729-42f8-ae4b-596a13c1800d

Scenarios for Reviewer to Test

:microscope: Quality checks

Pull Request (PR) checklist: