theiagen / public_health_bioinformatics

Bioinformatics workflows for genomic characterization, submission preparation, and genomic epidemiology of pathogens of public health concern.
GNU General Public License v3.0
34 stars 16 forks source link

update docker to version tag 2.23.0-2024-01 #293

Closed cimendes closed 6 months ago

cimendes commented 6 months ago

Closes #262

:hammer_and_wrench: Changes Being Made

Impacted Workflows/Tasks

All Theiaprok workflows

:brain: Context and Rationale

This PR updates the mlst database sync with pubmlst as of January 2024

New docker container: us-docker.pkg.dev/general-theiagen/staphb/mlst:2.23.0-2024-01

:clipboard: Workflow/Task Steps

N/A

Inputs

N/A

Outputs

N/A

Impacted Outputs

All mlst outputs

    File? ts_mlst_results = ts_mlst.ts_mlst_results
    String? ts_mlst_predicted_st = ts_mlst.ts_mlst_predicted_st
    String? ts_mlst_pubmlst_scheme = ts_mlst.ts_mlst_pubmlst_scheme
    String? ts_mlst_allelic_profile = ts_mlst.ts_mlst_allelic_profile
    String? ts_mlst_version = ts_mlst.ts_mlst_version
    File? ts_mlst_novel_alleles = ts_mlst.ts_mlst_novel_alleles
    String? ts_mlst_docker = ts_mlst.ts_mlst_docker

:test_tube: Testing

Locally

Local test passed with no issue on the mlst task

Terra

Underway

Scenarios for Reviewer to Test

All mlst calls are accurate with pubmlst database as of January 2024

:microscope: Quality checks

Pull Request (PR) checklist:

kevinlibuit commented 6 months ago

Thanks for the quick PR! Changes look great and this is ready for merging to main.

@kapsakcj wondering if we also want to mimic this practice for staphb images, i.e. creating mlst docker images with updated db. Hah, this conversation of docker-builds and dynamic databases continues!

kapsakcj commented 6 months ago

@kapsakcj wondering if we also want to mimic this practice for staphb images, i.e. creating mlst docker images with updated db. Hah, this conversation of docker-builds and dynamic databases continues!

Yes, I think it would be good to update the mlst docker image on a schedule, perhaps once a month. Let's chat about this at the next staphb/docker-builds dev meeting

cimendes commented 6 months ago

The documentation has been updated to reflect this merge!