theiagen / public_health_bioinformatics

Bioinformatics workflows for genomic characterization, submission preparation, and genomic epidemiology of pathogens of public health concern.
GNU General Public License v3.0
37 stars 17 forks source link

fix dockstore: add empty.json file and update .dockstore.yml with absolute paths to it #347

Closed kapsakcj closed 7 months ago

kapsakcj commented 7 months ago

This PR closes #344

🗑️ This dev branch should be deleted after merging to main.

:brain: Aim, Context and Functionality

:hammer_and_wrench: Impacted Workflows/Tasks & Changes Being Made

This will affect the behavior of the workflow(s) even if users don’t change any workflow inputs relative to the last version : Yes/No

Running this workflow on different occasions could result in different results, e.g. due to use of a live database, "latest" docker image, or stochastic data processing : Yes/No

:clipboard: Workflow/Task Step Changes

🔄 Data Processing

Docker/software or software versions changed:

Databases or database versions changed:

Data processing/commands changed:

File processing changed:

Compute resources changed:

➡️ Inputs

⬅️ Outputs

:test_tube: Testing

Test Dataset

Commandline Testing with MiniWDL or Cromwell (optional)

Terra Testing

Suggested Scenarios for Reviewer to Test

Theiagen Version Release Testing (optional)

:microscope: Final Developer Checklist

🎯 Reviewer Checklist

🗂️ Associated Documentation (to be completed by Theiagen developer)

kapsakcj commented 7 months ago

This seems to have resolved the dockstore syncing issue. We can see successful GH app sync logs here: image

and new development branches, like this one cjk-dockstore-updates are appearing in the list of versions for TheiaCov_Illumina_PE: image

I think we need to get this PR merged ASAP and then have others merge main branch back into their dev branches so changes propagate to new dev branches so the error goes away

cimendes commented 7 months ago

should we create the empty.json file in tests/inputs/ (given that the folder exists, maybe the file should exist too? Of not, idk if I prefer the solution with just /empty.json as not to confuse anyone :) @kapsakcj thank you for being so speedy!