theiagen / public_health_bioinformatics

Bioinformatics workflows for genomic characterization, submission preparation, and genomic epidemiology of pathogens of public health concern.
GNU General Public License v3.0
33 stars 15 forks source link

bug fix on fastq-dl task/SRA_fetch workflow for cpu variable #363

Closed kapsakcj closed 4 months ago

kapsakcj commented 4 months ago

Quick bugfix for a bug introduced in PR #310

This PR closes #362

Not planning to fill all of this ⬇️ out, it's a very simple PR. I'll run 1 test on Terra just to be sure

🗑️ This dev branch should be deleted after merging to main.

:brain: Aim, Context and Functionality

:hammer_and_wrench: Impacted Workflows/Tasks & Changes Being Made

This will affect the behavior of the workflow(s) even if users don’t change any workflow inputs relative to the last version : Yes/No

Running this workflow on different occasions could result in different results, e.g. due to use of a live database, "latest" docker image, or stochastic data processing : Yes/No

:clipboard: Workflow/Task Step Changes

🔄 Data Processing

Docker/software or software versions changed:

Databases or database versions changed:

Data processing/commands changed:

File processing changed:

Compute resources changed:

➡️ Inputs

⬅️ Outputs

:test_tube: Testing

Test Dataset

Commandline Testing with MiniWDL or Cromwell (optional)

Terra Testing

Suggested Scenarios for Reviewer to Test

Theiagen Version Release Testing (optional)

:microscope: Final Developer Checklist

🎯 Reviewer Checklist

🗂️ Associated Documentation (to be completed by Theiagen developer)

kapsakcj commented 4 months ago

Successful test in Terra here: https://app.terra.bio/#workspaces/theiagen-validations/curtis-sandbox-theiagen-validations/job_history/c71f2bc6-0cac-4d35-9c96-f498407b1446

Not necessary to update documentation with this code change