pangolin_update wf bug fix and hiding one input param related to Flu and organism_parameters subwf

kapsakcj commented 2 months ago

This PR closes #.

🗑️ This dev branch should be deleted after merging to main.

:brain: Aim, Context and Functionality

Pangolin_Update workflow: We missed deleting the nextclade_dataset_reference_input from org param call block when updating to nextclade V3 in #375 . This caused an error in Terra since the workflow was non-functional and did not pass miniwdl check or womtools validate
Additionally, for theiacov_ONT and TheiaCoV_Illumina_PE workflows: added gene_locations_bed_file to org param call blocks to hide optional input from user. This input should be hidden from the user in Terra because it will not be used even if a File is provided by the user.

:hammer_and_wrench: Impacted Workflows/Tasks & Changes Being Made

This will affect the behavior of the workflow(s) even if users don’t change any workflow inputs relative to the last version : No

Running this workflow on different occasions could result in different results, e.g. due to use of a live database, "latest" docker image, or stochastic data processing : No

:clipboard: Workflow/Task Step Changes

🔄 Data Processing

Nothing has changed, these are just workflow level Input changes

Docker/software or software versions changed: No

Databases or database versions changed: No

Data processing/commands changed: No

File processing changed: No

Compute resources changed: No

➡️ Inputs

for theiacov_ONT and TheiaCoV_Illumina_PE workflows: added gene_locations_bed_file to org param call blocks to hide optional input from user
nextclade_dataset_reference_input from org param call block for Pangolin_Update workflow

⬅️ Outputs

N/A

:test_tube: Testing

Test Dataset

Pangolin_Update test: 4 sars-cov-2 samples

TheiaCoV_Illumina_PE and ONT: Not sure? Perhaps test with Flu samples through both?

Commandline Testing with MiniWDL or Cromwell (optional)

N/A

Terra Testing

Pangolin_Update test: https://app.terra.bio/#workspaces/theiagen-validations/curtis-sandbox-theiagen-validations/job_history/8ef17805-b8d8-4094-9018-401cf7b53e7e ✅

workflow ran successfully:

TheiaCoV_Illumina_PE: https://app.terra.bio/#workspaces/theiagen-validations/PHB_Validation_nextcladeV3testing/job_history/521e50b0-db79-4396-b401-6a350def0a0b ~~⚠️ Just need to check that the workflows ran successfully~~ Workflows ran successfully ✅
TheiaCoV_ONT: https://app.terra.bio/#workspaces/theiagen-validations/PHB_Validation_nextcladeV3testing/job_history/723f8545-f8df-4eb8-9166-c829bfcc19fd ~~⚠️ Just need to check that the workflows ran successfully~~ Workflows ran successfully ✅

For both of these workflows ⬆️ , the gene_locations_bed_file input has been hidden from the user, as expected:

Suggested Scenarios for Reviewer to Test

For pangolin_update, any sars-cov-2 samples that have been previously run through Pangolin (via TheiaCoV workflows)

Likely test Flu samples through ILMN PE and ONT workflows

Theiagen Version Release Testing (optional)

Will changes require functional or validation testing (checking outputs etc) during the release? functional
Do new samples need to be added to validation datasets? If so, upload these to the appropriate validation workspace Google bucket (). Please describe the new samples here and why these have been chosen. No
Are there any output files that should be checked after running the version release testing? No

:microscope: Final Developer Checklist

[x] The workflow/task has been tested locally and results, including file contents, are as anticipated
[ ] The workflow/task has been tested on Terra and results, including file contents, are as anticipated
[x] The CI/CD has been adjusted and tests are passing (to be completed by Theiagen developer)
[x] Code changes follow the style guide

🎯 Reviewer Checklist

[ ] All impacted workflows/tasks have been tested on Terra with a different dataset than used for development
[ ] All reviewer-suggested scenarios have been tested and any additional
[ ] All changed results have been confirmed to be accurate
[ ] All workflows/tasks impacted by change/s have been tested using a standard validation dataset to ensure no unintended change of functionality
[ ] All code adheres to the style guide
[ ] MD5 sums have been updated
[ ] The PR author has addressed all comments

🗂️ Associated Documentation (to be completed by Theiagen developer)

[ ] Relevant documentation on the Public Health Resources "PHB Main" has been updated
[x] Workflow diagrams have been updated to reflect changes

cimendes commented 2 months ago

Testing flu here: https://app.terra.bio/#workspaces/theiagen-validations/Theiagen_Mendes_Sandbox/job_history/12c8a4c9-aea8-47e0-a74f-5cc230066d82

✅ All good!!

cimendes commented 2 months ago

Managed to import this branch without issue on Terra (failed with version in main) for Pangolin_Update_PHB

cimendes commented 2 months ago

Testing pango update here: https://app.terra.bio/#workspaces/theiagen-validations/Theiagen_Mendes_Sandbox/job_history/7c2b9d62-1df0-40c6-b000-7fc649aeb1ad

✅ working like a charm!

theiagen / public_health_bioinformatics