theiagen / public_health_bioinformatics

Bioinformatics workflows for genomic characterization, submission preparation, and genomic epidemiology of pathogens of public health concern.
GNU General Public License v3.0
33 stars 15 forks source link

theiacov_illumina_pe kraken output name change #417

Closed kapsakcj closed 2 months ago

kapsakcj commented 2 months ago

Also changed the name of the docker input param for the tbprofiler WDL task.

This PR closes #.

🗑️ This dev branch should be deleted after merging to main.

:brain: Aim, Context and Functionality

:hammer_and_wrench: Impacted Workflows/Tasks & Changes Being Made

This will affect the behavior of the workflow(s) even if users don’t change any workflow inputs relative to the last version : Yes/No

Running this workflow on different occasions could result in different results, e.g. due to use of a live database, "latest" docker image, or stochastic data processing : Yes/No

:clipboard: Workflow/Task Step Changes

🔄 Data Processing

Docker/software or software versions changed:

Databases or database versions changed:

Data processing/commands changed:

File processing changed:

Compute resources changed:

➡️ Inputs

⬅️ Outputs

:test_tube: Testing

Test Dataset

Commandline Testing with MiniWDL or Cromwell (optional)

Terra Testing

Suggested Scenarios for Reviewer to Test

Theiagen Version Release Testing (optional)

:microscope: Final Developer Checklist

🎯 Reviewer Checklist

🗂️ Associated Documentation (to be completed by Theiagen developer)

cimendes commented 2 months ago

image

cimendes commented 2 months ago

image

cimendes commented 2 months ago

image

kapsakcj commented 2 months ago

skipping testing for this PR specifically because we are about to run validation tests for the v2 release.

These are minimal changes that I'm confident will run appropriately (and the CI shows this)