theiagen / public_health_bioinformatics

Bioinformatics workflows for genomic characterization, submission preparation, and genomic epidemiology of pathogens of public health concern.
GNU General Public License v3.0
33 stars 15 forks source link

setting vadr_skip_length via organism_parameters subworkflow as this … #418

Closed kapsakcj closed 2 months ago

kapsakcj commented 2 months ago

…is taxa-specific. not tested yet

This PR closes #.

🗑️ This dev branch should be deleted after merging to main.

:brain: Aim, Context and Functionality

:hammer_and_wrench: Impacted Workflows/Tasks & Changes Being Made

This will affect the behavior of the workflow(s) even if users don’t change any workflow inputs relative to the last version : Yes/No

Running this workflow on different occasions could result in different results, e.g. due to use of a live database, "latest" docker image, or stochastic data processing : Yes/No

:clipboard: Workflow/Task Step Changes

🔄 Data Processing

Docker/software or software versions changed:

Databases or database versions changed:

Data processing/commands changed:

File processing changed:

Compute resources changed:

➡️ Inputs

⬅️ Outputs

:test_tube: Testing

Test Dataset

Commandline Testing with MiniWDL or Cromwell (optional)

Terra Testing

Suggested Scenarios for Reviewer to Test

Theiagen Version Release Testing (optional)

:microscope: Final Developer Checklist

🎯 Reviewer Checklist

🗂️ Associated Documentation (to be completed by Theiagen developer)

kapsakcj commented 2 months ago

Running a test of theiacov_illumina_PE here on a number of different organisms to see if vadr_skip_length input parameter set via organism_parameter subwf is functional or not: https://app.terra.bio/#workspaces/theiagen-validations/PHB_Validation_nextcladeV3testing/job_history/6abe6969-bfd9-44af-bd00-e780a9b66efe

kapsakcj commented 2 months ago

theiacov_ont test here (flu, SC2, MPox): https://app.terra.bio/#workspaces/theiagen-validations/PHB_Validation_nextcladeV3testing/job_history/93a0dcb3-65f6-4ee4-ad18-067df4394ef0

kapsakcj commented 2 months ago

will mark ready for review when my test workflows pass