theiagen / public_health_bioinformatics

Bioinformatics workflows for genomic characterization, submission preparation, and genomic epidemiology of pathogens of public health concern.
GNU General Public License v3.0
33 stars 15 forks source link

[Freyja_Dashboard] fix typo in freyja_dashboard output File variable name #482

Closed AndrewLangvt closed 1 month ago

AndrewLangvt commented 1 month ago

This PR closes #422 .

🗑️ This dev branch should be deleted after merging to main.

:brain: Aim, Context and Functionality

This PR resolves a trivial spelling error in the outputs of freyja workflow, specifically the field denoting freyja dashboard

:hammer_and_wrench: Impacted Workflows/Tasks & Changes Being Made

This will affect the behavior of the workflow(s) even if users don’t change any workflow inputs relative to the last version : No

Running this workflow on different occasions could result in different results, e.g. due to use of a live database, "latest" docker image, or stochastic data processing : No

:clipboard: Workflow/Task Step Changes

🔄 Data Processing

Docker/software or software versions changed: No

Databases or database versions changed: No

Data processing/commands changed: No

File processing changed: No

Compute resources changed: No

➡️ Inputs

No Change

⬅️ Outputs

No change to output files. Trivial change to spelling of output namespace.

:test_tube: Testing

Test Dataset

Commandline Testing with MiniWDL or Cromwell (optional)

Locally tested via MiniWDL check.

Terra Testing

https://app.terra.bio/#workspaces/theiagen-training-workspaces/Theiagen_Lang_Sandbox/job_history/d48b5156-a4ee-4812-9756-72f99a674aef

Suggested Scenarios for Reviewer to Test

Theiagen Version Release Testing (optional)

:microscope: Final Developer Checklist

🎯 Reviewer Checklist

🗂️ Associated Documentation (to be completed by Theiagen developer)

sage-wright commented 1 month ago

Code changes look good 👍 Testing here, will merge upon success.