theiagen / public_health_bioinformatics

Bioinformatics workflows for genomic characterization, submission preparation, and genomic epidemiology of pathogens of public health concern.
GNU General Public License v3.0
33 stars 15 forks source link

[TheiaProk] expose hicap outputs in theiaprok_fasta and theiaprok_ont #508

Closed cimendes closed 1 week ago

cimendes commented 2 weeks ago

This PR closes #285

🗑️ This dev branch should be deleted after merging to main.

:brain: Aim, Context and Functionality

In the TheiaProk_ONT and TheiaProk_FASTA workflow, the hicap task is launched for Haemophilus influenzae samples but the outputs are not currently included in the workflow outputs. This PR fixes this.

:hammer_and_wrench: Impacted Workflows/Tasks & Changes Being Made

This will affect the behavior of the workflow(s) even if users don’t change any workflow inputs relative to the last version : No

Running this workflow on different occasions could result in different results, e.g. due to use of a live database, "latest" docker image, or stochastic data processing : No

:clipboard: Workflow/Task Step Changes

🔄 Data Processing

Docker/software or software versions changed: N/A

Databases or database versions changed: N/A

Data processing/commands changed: N/A

File processing changed: N/A

Compute resources changed: N/A

➡️ Inputs

No outputs have been modified.

⬅️ Outputs

New outputs:

String? hicap_serotype
String? hicap_genes
File? hicap_results_tsv
String? hicap_version
String? hicap_docker

:test_tube: Testing

Test Dataset

Commandline Testing with MiniWDL or Cromwell (optional)

Terra Testing

Suggested Scenarios for Reviewer to Test

Theiagen Version Release Testing (optional)

:microscope: Final Developer Checklist

🎯 Reviewer Checklist

🗂️ Associated Documentation (to be completed by Theiagen developer)

michellescribner commented 1 week ago

TheiaProk_FASTA_PHB, 5 Haemophilus influenzae samples: https://app.terra.bio/#workspaces/theiagen-validations/Theiagen_Scribner_Sandbox/job_history/cdefa288-5629-4b3f-884f-dd288806b963 TheiaProk_ONT_PHB, 2 Haemophilus influenzae samples: https://app.terra.bio/#workspaces/theiagen-validations/Theiagen_Scribner_Sandbox/job_history/43df7c1b-ead1-4ae4-8e9f-3d63c7f702b2

TheiaProk_ONT_PHB samples above failed at dragonflye step for unknown reasons, and 2 substitute samples from NCBI also were screened at the clean read screen step.

Finally, I used the same test samples as Ines above just to confirm successful function test: https://app.terra.bio/#workspaces/theiagen-validations/Theiagen_Scribner_Sandbox/job_history/5ec4cfa2-7f3a-4cd4-bf0c-f7da21636c8c