theiagen / public_health_bioinformatics

Bioinformatics workflows for genomic characterization, submission preparation, and genomic epidemiology of pathogens of public health concern.
GNU General Public License v3.0
33 stars 15 forks source link

[all workflows] upgrade PHB version to 2.1.0 #517

Closed kapsakcj closed 1 week ago

kapsakcj commented 1 week ago

This PR closes #513

🗑️ This dev branch should be deleted after merging to main.

:brain: Aim, Context and Functionality

upgrade the PHB version to 2.1.0 ahead of the release

:hammer_and_wrench: Impacted Workflows/Tasks & Changes Being Made

This will affect the behavior of the workflow(s) even if users don’t change any workflow inputs relative to the last version : Yes

Running this workflow on different occasions could result in different results, e.g. due to use of a live database, "latest" docker image, or stochastic data processing : No

:clipboard: Workflow/Task Step Changes

🔄 Data Processing

Docker/software or software versions changed: task_versioning.wdl upgraded to output PHB v2.1.0

Databases or database versions changed: N/A

Data processing/commands changed: N/A

File processing changed: N/A

Compute resources changed: N/A

➡️ Inputs

N/A

⬅️ Outputs

All PHB workflows will now output PHB v2.1.0

:test_tube: Testing

Test Dataset

Doesn't matter, just need to test on at least one workflow

Commandline Testing with MiniWDL or Cromwell (optional)

skipped

Terra Testing

Testing w theiacov_fasta: https://app.terra.bio/#workspaces/theiagen-validations/curtis-sandbox-theiagen-validations/job_history/c5986459-6e09-4c2c-949e-120f893f1c55 ⚠️ need to review version output

✅ version output is updated as expected

Suggested Scenarios for Reviewer to Test

Test any workflow that runs the task_versioning.wdl task, which is almost everything

Theiagen Version Release Testing (optional)

:microscope: Final Developer Checklist

🎯 Reviewer Checklist

🗂️ Associated Documentation (to be completed by Theiagen developer)

kapsakcj commented 1 week ago

I am not entirely sure what in the documentation other than the main Notion page title "PHB v2.1.0" needs to be updated so I have left that unchecked

cimendes commented 1 week ago

the ⭐ strikes again!