theiagen / public_health_bioinformatics

Bioinformatics workflows for genomic characterization, submission preparation, and genomic epidemiology of pathogens of public health concern.
GNU General Public License v3.0
37 stars 17 forks source link

Fix typo in Terra_2_NCBI Wastewater metadata #519

Closed michellescribner closed 3 months ago

michellescribner commented 3 months ago

This PR fixes a small typo identified while troubleshooting with a laboratory using the Terra_2_NCBI_PHB workflow to submit SC2 wastewater data.

🗑️ This dev branch should be deleted after merging to main.

:brain: Aim, Context and Functionality

:hammer_and_wrench: Impacted Workflows/Tasks & Changes Being Made

This will affect the behavior of the workflow(s) even if users don’t change any workflow inputs relative to the last version : Yes

Running this workflow on different occasions could result in different results, e.g. due to use of a live database, "latest" docker image, or stochastic data processing : No

:clipboard: Workflow/Task Step Changes

🔄 Data Processing

When running Terra_2_NCBI_PHB to submit wastewater data to NCBI, the workflow currently searches for a metadata column called ww_surv_target_1_known_presence within the user's data table. However, the metadata field anticipated by NCBI should be called ww_surv_target_1_known_present. This PR fixes this small typo.

➡️ Inputs

Terra Testing

https://app.terra.bio/#workspaces/dhss-dph-terra/Wastewater/job_history/d1d49caa-26cb-4dc8-9fd6-da89297cb155

Suggested Scenarios for Reviewer to Test

Theiagen Version Release Testing (optional)

:microscope: Final Developer Checklist

🎯 Reviewer Checklist

🗂️ Associated Documentation (to be completed by Theiagen developer)