theiagen / public_health_viral_genomics

Bioinformatics workflows for genomic characterization, submission preparation, and genomic epidemiology of viral pathogens of concern, especially SARS-CoV-2
https://public-health-viral-genomics-theiagen.readthedocs.io/
GNU Affero General Public License v3.0
40 stars 17 forks source link

Adds VADR task and outputs for MPXV #174

Closed kapsakcj closed 2 years ago

kapsakcj commented 2 years ago

Setting as a draft for now, until testing in Terra is done and #171 is merged. The changes from PR 171 are included in this PR as well.

The design strategy was to alter the VADR task as little as possible and allow the user to define VADR input params to control between SARS-CoV-2 usage and MPXV. We will provide input JSONs to avoid typos.

This PR:

VADR_Update workflow does not require changes, all that needs adjusted is the input parameters

Input parameters that must be specified:

I'm expecting CI to fail, as there are a good number of changes introduced here. Will address later after we're happy w the code

kapsakcj commented 2 years ago

Planning to restructure so that the call for the VADR task appears in the block where organism is set to sarscov2 or mpxv.

Please do not review for now

kapsakcj commented 2 years ago

I plan on closing this PR and opening another one with the branch cjk-vadr-consolidation which will include the changes from this PR (dev branch started from this dev branch cjk-vadr-mpx) and additionally consolidate to using the same task call block in all workflows, and thus only 4 VADR workflow-level outputs instead of having separate ones for sars-cov-2 and mpxv.